Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99c8f2e6 authored by Nur Hussein's avatar Nur Hussein Committed by Greg Kroah-Hartman
Browse files

drm/tegra: Avoid potential 32-bit integer overflow 



[ Upstream commit 2429b3c529da29d4277d519bd66d034842dcd70c ]

In tegra_sor_compute_config(), the 32-bit value mode->clock is
multiplied by 1000, and assigned to the u64 variable pclk. We can avoid
a potential 32-bit integer overflow by casting mode->clock to u64 before
we do the arithmetic and assignment.

Signed-off-by: default avatarNur Hussein <hussein@unixcat.org>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ccae2233

drivers/gpu/drm/tegra/sor.c

+1 −1
Original line number Diff line number Diff line
@@ -906,7 +906,7 @@ static int tegra_sor_compute_config(struct tegra_sor *sor, 
				    struct drm_dp_link *link)

{

	const u64 f = 100000, link_rate = link->rate * 1000;

	const u64 pclk = mode->clock * 1000;

	const u64 pclk = (u64)mode->clock * 1000;

	u64 input, output, watermark, num;

	struct tegra_sor_params params;

	u32 num_syms_per_line;