Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99669d94 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Greg Kroah-Hartman
Browse files

ethernet: aeroflex: fix potential skb leak in greth_init_rings() 



[ Upstream commit 063a932b64db3317ec020c94466fe52923a15f60 ]

The greth_init_rings() function won't free the newly allocated skb when
dma_mapping_error() returns error, so add dev_kfree_skb() to fix it.

Compile tested only.

Fixes: d4c41139 ("net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/1670134149-29516-1-git-send-email-zhangchangzhong@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 3295582c

drivers/net/ethernet/aeroflex/greth.c

+1 −0
Original line number Diff line number Diff line
@@ -258,6 +258,7 @@ static int greth_init_rings(struct greth_private *greth) 
			if (dma_mapping_error(greth->dev, dma_addr)) {

				if (netif_msg_ifup(greth))

					dev_err(greth->dev, "Could not create initial DMA mapping\n");

				dev_kfree_skb(skb);

				goto cleanup;

			}

			greth->rx_skbuff[i] = skb;