Commit 995c3fc3 authored Jun 17, 2021 by Yang Yingliang Committed by Greg Kroah-Hartman Jul 19, 2021

net: sched: fix error return code in tcf_del_walker()



[ Upstream commit 55d96f72e8ddc0a294e0b9c94016edbb699537e1 ]

When nla_put_u32() fails, 'ret' could be 0, it should
return error code in tcf_del_walker().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent bba660a0

net/sched/act_api.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -316,7 +316,8 @@ static int tcf_del_walker(struct tcf_idrinfo idrinfo, struct sk_buff skb,
		}
		mutex_unlock(&idrinfo->lock);

		if (nla_put_u32(skb, TCA_FCNT, n_i))
		ret = nla_put_u32(skb, TCA_FCNT, n_i);
		if (ret)
		goto nla_put_failure;
		nla_nest_end(skb, nest);