Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 993a8067 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm: Do not accept garbage mode aspect ratio flags 



Don't let userspace feed us any old garbage in the mode aspect ratio
flags.

Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190620142639.17518-3-ville.syrjala@linux.intel.com


Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 700710e9

drivers/gpu/drm/drm_modes.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -1977,9 +1977,11 @@ int drm_mode_convert_umode(struct drm_device *dev, 
	case DRM_MODE_FLAG_PIC_AR_256_135:

	case DRM_MODE_FLAG_PIC_AR_256_135:

		out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_256_135;

		out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_256_135;

		break;

		break;

	default:

	case DRM_MODE_FLAG_PIC_AR_NONE:

		out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;

		out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;

		break;

		break;

	default:

		return -EINVAL;

	}

	}





	out->status = drm_mode_validate_driver(dev, out);

	out->status = drm_mode_validate_driver(dev, out);