Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9913f74f authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Inki Dae
Browse files

drm/exynos: ipp: Add IPP v2 framework 



This patch adds Exynos IPP v2 subsystem and userspace API.

New userspace API is focused ONLY on memory-to-memory image processing.
The two remainging operation modes of obsolete IPP v1 API (framebuffer
writeback and local-path output with image processing) can be implemented
using standard DRM features: writeback connectors and additional DRM planes
with scaling features.

V2 IPP userspace API is based on stateless approach, which much better fits
to memory-to-memory image processing model. It also provides support for
all image formats, which are both already defined in DRM API and supported
by the existing IPP hardware modules.

The API consists of the following ioctls:
- DRM_IOCTL_EXYNOS_IPP_GET_RESOURCES: to enumerate all available image
  processing modules,
- DRM_IOCTL_EXYNOS_IPP_GET_CAPS: to query capabilities and supported image
  formats of given IPP module,
- DRM_IOCTL_EXYNOS_IPP_GET_LIMITS: to query hardware limitiations for
  selected image format of given IPP module,
- DRM_IOCTL_EXYNOS_IPP_COMMIT: to perform operation described by the
  provided structures (source and destination buffers, operation rectangle,
  transformation, etc).

The proposed userspace API is extensible. In the future more advanced image
processing operations can be defined to support for example blending.

Userspace API is fully functional also on DRM render nodes, so it is not
limited to the root/privileged client.

Internal driver API also has been completely rewritten. New IPP core
performs all possible input validation, checks and object life-time
control. The drivers can focus only on writing configuration to hardware
registers. Stateless nature of DRM_IOCTL_EXYNOS_IPP_COMMIT ioctl simplifies
the driver API. Minimal driver needs to provide a single callback for
starting processing and an array with supported image formats.

Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Tested-by: default avatarHoegeun Kwon <hoegeun.kwon@samsung.com>
Merge conflict so merged manually.
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent 5fae288d

drivers/gpu/drm/exynos/Kconfig

+3 −0
Original line number Original line Diff line number Diff line
@@ -95,6 +95,9 @@ config DRM_EXYNOS_G2D 
	help

	help

	  Choose this option if you want to use Exynos G2D for DRM.

	  Choose this option if you want to use Exynos G2D for DRM.





config DRM_EXYNOS_IPP

	bool



config DRM_EXYNOS_FIMC

config DRM_EXYNOS_FIMC

	bool "FIMC"

	bool "FIMC"

	depends on BROKEN && MFD_SYSCON

	depends on BROKEN && MFD_SYSCON

drivers/gpu/drm/exynos/Makefile

+1 −0
Original line number Original line Diff line number Diff line
@@ -18,6 +18,7 @@ exynosdrm-$(CONFIG_DRM_EXYNOS_MIXER) += exynos_mixer.o 
exynosdrm-$(CONFIG_DRM_EXYNOS_HDMI)	+= exynos_hdmi.o

exynosdrm-$(CONFIG_DRM_EXYNOS_HDMI)	+= exynos_hdmi.o

exynosdrm-$(CONFIG_DRM_EXYNOS_VIDI)	+= exynos_drm_vidi.o

exynosdrm-$(CONFIG_DRM_EXYNOS_VIDI)	+= exynos_drm_vidi.o

exynosdrm-$(CONFIG_DRM_EXYNOS_G2D)	+= exynos_drm_g2d.o

exynosdrm-$(CONFIG_DRM_EXYNOS_G2D)	+= exynos_drm_g2d.o

exynosdrm-$(CONFIG_DRM_EXYNOS_IPP)	+= exynos_drm_ipp.o

exynosdrm-$(CONFIG_DRM_EXYNOS_FIMC)	+= exynos_drm_fimc.o

exynosdrm-$(CONFIG_DRM_EXYNOS_FIMC)	+= exynos_drm_fimc.o

exynosdrm-$(CONFIG_DRM_EXYNOS_ROTATOR)	+= exynos_drm_rotator.o

exynosdrm-$(CONFIG_DRM_EXYNOS_ROTATOR)	+= exynos_drm_rotator.o

exynosdrm-$(CONFIG_DRM_EXYNOS_GSC)	+= exynos_drm_gsc.o

exynosdrm-$(CONFIG_DRM_EXYNOS_GSC)	+= exynos_drm_gsc.o

drivers/gpu/drm/exynos/exynos_drm_drv.c

+20 −2
Original line number Original line Diff line number Diff line
@@ -27,15 +27,23 @@ 
#include "exynos_drm_fb.h"

#include "exynos_drm_fb.h"

#include "exynos_drm_gem.h"

#include "exynos_drm_gem.h"

#include "exynos_drm_plane.h"

#include "exynos_drm_plane.h"

#include "exynos_drm_ipp.h"

#include "exynos_drm_vidi.h"

#include "exynos_drm_vidi.h"

#include "exynos_drm_g2d.h"

#include "exynos_drm_g2d.h"

#include "exynos_drm_iommu.h"

#include "exynos_drm_iommu.h"





#define DRIVER_NAME	"exynos"

#define DRIVER_NAME	"exynos"

#define DRIVER_DESC	"Samsung SoC DRM"

#define DRIVER_DESC	"Samsung SoC DRM"

#define DRIVER_DATE	"20110530"

#define DRIVER_DATE	"20180330"



/*

 * Interface history:

 *

 * 1.0 - Original version

 * 1.1 - Upgrade IPP driver to version 2.0

 */

#define DRIVER_MAJOR	1

#define DRIVER_MAJOR	1

#define DRIVER_MINOR	0

#define DRIVER_MINOR	1





int exynos_atomic_check(struct drm_device *dev,

int exynos_atomic_check(struct drm_device *dev,

			struct drm_atomic_state *state)

			struct drm_atomic_state *state)
@@ -108,6 +116,16 @@ static const struct drm_ioctl_desc exynos_ioctls[] = { 
			DRM_AUTH | DRM_RENDER_ALLOW),

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_G2D_EXEC, exynos_g2d_exec_ioctl,

	DRM_IOCTL_DEF_DRV(EXYNOS_G2D_EXEC, exynos_g2d_exec_ioctl,

			DRM_AUTH | DRM_RENDER_ALLOW),

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_IPP_GET_RESOURCES,

			exynos_drm_ipp_get_res_ioctl,

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_IPP_GET_CAPS, exynos_drm_ipp_get_caps_ioctl,

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_IPP_GET_LIMITS,

			exynos_drm_ipp_get_limits_ioctl,

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_IPP_COMMIT, exynos_drm_ipp_commit_ioctl,

			DRM_AUTH | DRM_RENDER_ALLOW),

};

};





static const struct file_operations exynos_drm_driver_fops = {

static const struct file_operations exynos_drm_driver_fops = {