Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 989f405a authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by David S. Miller
Browse files

net: dsa: mv88e6xxx: fix comments and macro names in mv88e6390_g1_mgmt_rsvd2cpu 



The macros have an extraneous '800' (after 0180C2 there should be just
six nibbles, with X representing one), while the comments have
interchanged c2 and 80 and an extra :00.

Signed-off-by: default avatarRasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b33bc2b8

drivers/net/dsa/mv88e6xxx/global1.c

+8 −8
Original line number Diff line number Diff line
@@ -379,26 +379,26 @@ int mv88e6390_g1_mgmt_rsvd2cpu(struct mv88e6xxx_chip *chip) 
	u16 ptr;

	int err;



	/* 01:c2:80:00:00:00:00-01:c2:80:00:00:00:07 are Management */

	ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000000XLO;

	/* 01:80:c2:00:00:00-01:80:c2:00:00:07 are Management */

	ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200000XLO;

	err = mv88e6390_g1_monitor_write(chip, ptr, 0xff);

	if (err)

		return err;



	/* 01:c2:80:00:00:00:08-01:c2:80:00:00:00:0f are Management */

	ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000000XHI;

	/* 01:80:c2:00:00:08-01:80:c2:00:00:0f are Management */

	ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200000XHI;

	err = mv88e6390_g1_monitor_write(chip, ptr, 0xff);

	if (err)

		return err;



	/* 01:c2:80:00:00:00:20-01:c2:80:00:00:00:27 are Management */

	ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000002XLO;

	/* 01:80:c2:00:00:20-01:80:c2:00:00:27 are Management */

	ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200002XLO;

	err = mv88e6390_g1_monitor_write(chip, ptr, 0xff);

	if (err)

		return err;



	/* 01:c2:80:00:00:00:28-01:c2:80:00:00:00:2f are Management */

	ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000002XHI;

	/* 01:80:c2:00:00:28-01:80:c2:00:00:2f are Management */

	ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200002XHI;

	err = mv88e6390_g1_monitor_write(chip, ptr, 0xff);

	if (err)

		return err;

drivers/net/dsa/mv88e6xxx/global1.h

+4 −4
Original line number Diff line number Diff line
@@ -190,10 +190,10 @@ 
#define MV88E6390_G1_MONITOR_MGMT_CTL				0x1a

#define MV88E6390_G1_MONITOR_MGMT_CTL_UPDATE			0x8000

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_MASK			0x3f00

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000000XLO	0x0000

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000000XHI	0x0100

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000002XLO	0x0200

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000002XHI	0x0300

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200000XLO	0x0000

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200000XHI	0x0100

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200002XLO	0x0200

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200002XHI	0x0300

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_INGRESS_DEST		0x2000

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_EGRESS_DEST		0x2100

#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_CPU_DEST		0x3000