Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 987c658a authored by Edward Cree's avatar Edward Cree Committed by David S. Miller
Browse files

sfc: fix ARFS expiry check on EF10 



Owing to a missing conditional, the result of rps_may_expire_flow() was
 being ignored and filters were being removed even if we'd decided not to
 expire them.

Fixes: f8d62037 ("sfc: ARFS filter IDs")
Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ded8b9c7

drivers/net/ethernet/sfc/ef10.c

+3 −2
Original line number Diff line number Diff line
@@ -4784,6 +4784,7 @@ static bool efx_ef10_filter_rfs_expire_one(struct efx_nic *efx, u32 flow_id, 
	 * will set rule->filter_id to EFX_ARFS_FILTER_ID_PENDING, meaning that

	 * the rule is not removed by efx_rps_hash_del() below.

	 */

	if (ret)

		ret = efx_ef10_filter_remove_internal(efx, 1U << spec->priority,

						      filter_idx, true) == 0;

	/* While we can't safely dereference rule (we dropped the lock), we can