Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9823a525 authored by Thomas Meyer's avatar Thomas Meyer Committed by Felipe Balbi
Browse files

usb: gadget: Use kcalloc instead of kzalloc to allocate array 

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107



Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Acked-by: default avatarMichal Nazarewicz <[4]mina86@mina86.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent b294b203

drivers/usb/gadget/f_fs.c

+1 −1
Original line number Diff line number Diff line
@@ -1408,7 +1408,7 @@ static int ffs_epfiles_create(struct ffs_data *ffs) 
	ENTER();



	count = ffs->eps_count;

	epfiles = kzalloc(count * sizeof *epfiles, GFP_KERNEL);

	epfiles = kcalloc(count, sizeof(*epfiles), GFP_KERNEL);

	if (!epfiles)

		return -ENOMEM;

drivers/usb/gadget/f_mass_storage.c

+1 −1
Original line number Diff line number Diff line
@@ -2775,7 +2775,7 @@ static struct fsg_common *fsg_common_init(struct fsg_common *common, 
	 * Create the LUNs, open their backing files, and register the

	 * LUN devices in sysfs.

	 */

	curlun = kzalloc(nluns * sizeof *curlun, GFP_KERNEL);

	curlun = kcalloc(nluns, sizeof(*curlun), GFP_KERNEL);

	if (unlikely(!curlun)) {

		rc = -ENOMEM;

		goto error_release;