Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 981024ab authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Greg Kroah-Hartman
Browse files

drm/amdgpu: Fix PCI device refcount leak in amdgpu_atrm_get_bios() 



[ Upstream commit ca54639c7752edf1304d92ff4d0c049d4efc9ba0 ]

As comment of pci_get_class() says, it returns a pci_device with its
refcount increased and decreased the refcount for the input parameter
@from if it is not NULL.

If we break the loop in amdgpu_atrm_get_bios() with 'pdev' not NULL, we
need to call pci_dev_put() to decrease the refcount. Add the missing
pci_dev_put() to avoid refcount leak.

Fixes: d38ceaf9 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: default avatarXiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 470a7798

drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c

+1 −0
Original line number Diff line number Diff line
@@ -313,6 +313,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev) 


	if (!found)

		return false;

	pci_dev_put(pdev);



	adev->bios = kmalloc(size, GFP_KERNEL);

	if (!adev->bios) {