Commit 97eb89bb authored Sep 26, 2008 by Benny Halevy Committed by J. Bruce Fields Sep 29, 2008

nfsd: do_probe_callback should not clear rpc stats



Now that cb_stats are static (since commit
ff7d9756)
there's no need to clear them.

Initially I thought it might make sense to do
that every callback probing but since the stats
are per-program and they are shared between possibly
several client callback instances, zeroing them out
seems like the wrong thing to do.

Note that that commit also introduced a bug
since stats.program is also being cleared in the process
and it is not restored after the memset as it used to be.

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

parent db820d63

fs/nfsd/nfs4callback.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -397,9 +397,6 @@ static int do_probe_callback(void *data)
		addr.sin_port = htons(cb->cb_port);
		addr.sin_addr.s_addr = htonl(cb->cb_addr);

		/* Initialize rpc_stat */
		memset(args.program->stats, 0, sizeof(struct rpc_stat));

		/* Create RPC client */
		client = rpc_create(&args);
		if (IS_ERR(client)) {