Commit 9718e5df authored Mar 22, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman Mar 25, 2013

staging: comedi: ni_labpc: remove unnecessary test of dev->irq



The ai subdevice (*do_cmd) pointer is only initialized if the
driver has successfully requested the interrupt. The extra test
in labpc_ai_cmd() is not necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fe7fc72a

drivers/staging/comedi/drivers/ni_labpc.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -858,11 +858,6 @@ static int labpc_ai_cmd(struct comedi_device dev, struct comedi_subdevice s)
		enum scan_mode mode;
		unsigned long flags;

		if (!dev->irq) {
		comedi_error(dev, "no irq assigned, cannot perform command");
		return -1;
		}

		range = CR_RANGE(cmd->chanlist[0]);
		aref = CR_AREF(cmd->chanlist[0]);