Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96fc3da6 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

ASoC: fsl: Fix refcount leak in imx_sgtl5000_probe 



[ Upstream commit 41cd312dfe980af869c3503b4d38e62ed20dd3b7 ]

of_find_i2c_device_by_node() takes a reference,
In error paths, we should call put_device() to drop
the reference to aviod refount leak.

Fixes: 81e8e492 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarFabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20220511065803.3957-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ddb1a77f

sound/soc/fsl/imx-sgtl5000.c

+8 −6
Original line number Diff line number Diff line
@@ -120,19 +120,19 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) 
	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);

	if (!data) {

		ret = -ENOMEM;

		goto fail;

		goto put_device;

	}



	comp = devm_kzalloc(&pdev->dev, 3 * sizeof(*comp), GFP_KERNEL);

	if (!comp) {

		ret = -ENOMEM;

		goto fail;

		goto put_device;

	}



	data->codec_clk = clk_get(&codec_dev->dev, NULL);

	if (IS_ERR(data->codec_clk)) {

		ret = PTR_ERR(data->codec_clk);

		goto fail;

		goto put_device;

	}



	data->clk_frequency = clk_get_rate(data->codec_clk);
@@ -158,10 +158,10 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) 
	data->card.dev = &pdev->dev;

	ret = snd_soc_of_parse_card_name(&data->card, "model");

	if (ret)

		goto fail;

		goto put_device;

	ret = snd_soc_of_parse_audio_routing(&data->card, "audio-routing");

	if (ret)

		goto fail;

		goto put_device;

	data->card.num_links = 1;

	data->card.owner = THIS_MODULE;

	data->card.dai_link = &data->dai;
@@ -176,7 +176,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) 
		if (ret != -EPROBE_DEFER)

			dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n",

				ret);

		goto fail;

		goto put_device;

	}



	of_node_put(ssi_np);
@@ -184,6 +184,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) 


	return 0;



put_device:

	put_device(&codec_dev->dev);

fail:

	if (data && !IS_ERR(data->codec_clk))

		clk_put(data->codec_clk);