Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96df988b authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Mauro Carvalho Chehab
Browse files

[media] cx88: Fix possible leak in cx8802_probe() 



In case allocation vb2_dma_sg_init_ctx() fails during cx8802_probe(), the
already allocated cx8802 device structure memory is not freed in the used
exit path. Thus adapt the cleanup handling accordingly. Detected by Coverity
CID 1260065.

Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 2160abb2

drivers/media/pci/cx88/cx88-mpeg.c

+2 −1
Original line number Diff line number Diff line
@@ -732,7 +732,7 @@ static int cx8802_probe(struct pci_dev *pci_dev, 
	dev->alloc_ctx = vb2_dma_sg_init_ctx(&pci_dev->dev);

	if (IS_ERR(dev->alloc_ctx)) {

		err = PTR_ERR(dev->alloc_ctx);

		goto fail_core;

		goto fail_dev;

	}

	dev->core = core;
@@ -754,6 +754,7 @@ static int cx8802_probe(struct pci_dev *pci_dev, 


 fail_free:

	vb2_dma_sg_cleanup_ctx(dev->alloc_ctx);

 fail_dev:

	kfree(dev);

 fail_core:

	core->dvbdev = NULL;