Commit 966eba93 authored Oct 08, 2018 by Paul Mackerras Committed by Michael Ellerman Oct 09, 2018

KVM: PPC: Book3S HV: Remove left-over code in XICS-on-XIVE emulation



This removes code that clears the external interrupt pending bit in
the pending_exceptions bitmap.  This is left over from an earlier
iteration of the code where this bit was set when an escalation
interrupt arrived in order to wake the vcpu from cede.  Currently
we set the vcpu->arch.irq_pending flag instead for this purpose.
Therefore there is no need to do anything with the pending_exceptions
bitmap.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent d24ea8a7

arch/powerpc/kvm/book3s_xive_template.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -280,14 +280,6 @@ X_STATIC unsigned long GLUE(X_PFX,h_xirr)(struct kvm_vcpu *vcpu)
		/* First collect pending bits from HW */
		GLUE(X_PFX,ack_pending)(xc);

		/*
		* Cleanup the old-style bits if needed (they may have been
		* set by pull or an escalation interrupts).
		*/
		if (test_bit(BOOK3S_IRQPRIO_EXTERNAL, &vcpu->arch.pending_exceptions))
		clear_bit(BOOK3S_IRQPRIO_EXTERNAL,
		&vcpu->arch.pending_exceptions);

		pr_devel(" new pending=0x%02x hw_cppr=%d cppr=%d\n",
		xc->pending, xc->hw_cppr, xc->cppr);