Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96490a1c authored by Weihang Li's avatar Weihang Li Committed by David S. Miller
Browse files

net: hns3: remove reset after command send failed 



It's meaningless to trigger reset when failed to send command to IMP,
because the failure is usually caused by no authority, illegal command
and so on. When that happened, we just need to return the status code
for further debugging.

Signed-off-by: default avatarWeihang Li <liweihang@hisilicon.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7b8f622e

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c

+0 −10
Original line number Diff line number Diff line
@@ -1653,8 +1653,6 @@ int hclge_handle_hw_msix_error(struct hclge_dev *hdev, 
	if (ret) {

		dev_err(dev, "fail(%d) to query msix int status bd num\n",

			ret);

		/* reset everything for now */

		set_bit(HNAE3_GLOBAL_RESET, reset_requests);

		return ret;

	}
@@ -1675,8 +1673,6 @@ int hclge_handle_hw_msix_error(struct hclge_dev *hdev, 
	if (ret) {

		dev_err(dev, "query all mpf msix int cmd failed (%d)\n",

			ret);

		/* reset everything for now */

		set_bit(HNAE3_GLOBAL_RESET, reset_requests);

		goto msi_error;

	}
@@ -1710,8 +1706,6 @@ int hclge_handle_hw_msix_error(struct hclge_dev *hdev, 
	if (ret) {

		dev_err(dev, "clear all mpf msix int cmd failed (%d)\n",

			ret);

		/* reset everything for now */

		set_bit(HNAE3_GLOBAL_RESET, reset_requests);

		goto msi_error;

	}
@@ -1725,8 +1719,6 @@ int hclge_handle_hw_msix_error(struct hclge_dev *hdev, 
	if (ret) {

		dev_err(dev, "query all pf msix int cmd failed (%d)\n",

			ret);

		/* reset everything for now */

		set_bit(HNAE3_GLOBAL_RESET, reset_requests);

		goto msi_error;

	}
@@ -1767,8 +1759,6 @@ int hclge_handle_hw_msix_error(struct hclge_dev *hdev, 
	if (ret) {

		dev_err(dev, "clear all pf msix int cmd failed (%d)\n",

			ret);

		/* reset everything for now */

		set_bit(HNAE3_GLOBAL_RESET, reset_requests);

	}



	/* query and clear mac tnl interruptions */