Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9638beb4 authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Greg Kroah-Hartman
Browse files

nvmet-tcp: fix a crash in nvmet_req_complete() 



[ Upstream commit 0849a5441358cef02586fb2d60f707c0db195628 ]

in nvmet_tcp_handle_h2c_data_pdu(), if the host sends a data_offset
different from rbytes_done, the driver ends up calling nvmet_req_complete()
passing a status error.
The problem is that at this point cmd->req is not yet initialized,
the kernel will crash after dereferencing a NULL pointer.

Fix the bug by replacing the call to nvmet_req_complete() with
nvmet_tcp_fatal_error().

Fixes: 872d26a3 ("nvmet-tcp: add NVMe over TCP target driver")
Reviewed-by: default avatarKeith Busch <kbsuch@kernel.org>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ee5e7632

drivers/nvme/target/tcp.c

+1 −2
Original line number Diff line number Diff line
@@ -886,8 +886,7 @@ static int nvmet_tcp_handle_h2c_data_pdu(struct nvmet_tcp_queue *queue) 
			data->ttag, le32_to_cpu(data->data_offset),

			cmd->rbytes_done);

		/* FIXME: use path and transport errors */

		nvmet_req_complete(&cmd->req,

			NVME_SC_INVALID_FIELD | NVME_SC_DNR);

		nvmet_tcp_fatal_error(queue);

		return -EPROTO;

	}