Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9616dda1 authored by Leonardo Bras's avatar Leonardo Bras Committed by Michael Ellerman
Browse files

powerpc/pseries/hotplug-memory.c: Replace nested ifs by switch-case 



I noticed these nested ifs can be easily replaced by switch-cases,
which can improve readability.

Signed-off-by: default avatarLeonardo Bras <leonardo@linux.ibm.com>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190801225251.17864-1-leonardo@linux.ibm.com
parent 1ebe0dcc

arch/powerpc/platforms/pseries/hotplug-memory.c

+18 −8
Original line number Diff line number Diff line
@@ -880,34 +880,44 @@ int dlpar_memory(struct pseries_hp_errorlog *hp_elog) 


	switch (hp_elog->action) {

	case PSERIES_HP_ELOG_ACTION_ADD:

		if (hp_elog->id_type == PSERIES_HP_ELOG_ID_DRC_COUNT) {

		switch (hp_elog->id_type) {

		case PSERIES_HP_ELOG_ID_DRC_COUNT:

			count = hp_elog->_drc_u.drc_count;

			rc = dlpar_memory_add_by_count(count);

		} else if (hp_elog->id_type == PSERIES_HP_ELOG_ID_DRC_INDEX) {

			break;

		case PSERIES_HP_ELOG_ID_DRC_INDEX:

			drc_index = hp_elog->_drc_u.drc_index;

			rc = dlpar_memory_add_by_index(drc_index);

		} else if (hp_elog->id_type == PSERIES_HP_ELOG_ID_DRC_IC) {

			break;

		case PSERIES_HP_ELOG_ID_DRC_IC:

			count = hp_elog->_drc_u.ic.count;

			drc_index = hp_elog->_drc_u.ic.index;

			rc = dlpar_memory_add_by_ic(count, drc_index);

		} else {

			break;

		default:

			rc = -EINVAL;

			break;

		}



		break;

	case PSERIES_HP_ELOG_ACTION_REMOVE:

		if (hp_elog->id_type == PSERIES_HP_ELOG_ID_DRC_COUNT) {

		switch (hp_elog->id_type) {

		case PSERIES_HP_ELOG_ID_DRC_COUNT:

			count = hp_elog->_drc_u.drc_count;

			rc = dlpar_memory_remove_by_count(count);

		} else if (hp_elog->id_type == PSERIES_HP_ELOG_ID_DRC_INDEX) {

			break;

		case PSERIES_HP_ELOG_ID_DRC_INDEX:

			drc_index = hp_elog->_drc_u.drc_index;

			rc = dlpar_memory_remove_by_index(drc_index);

		} else if (hp_elog->id_type == PSERIES_HP_ELOG_ID_DRC_IC) {

			break;

		case PSERIES_HP_ELOG_ID_DRC_IC:

			count = hp_elog->_drc_u.ic.count;

			drc_index = hp_elog->_drc_u.ic.index;

			rc = dlpar_memory_remove_by_ic(count, drc_index);

		} else {

			break;

		default:

			rc = -EINVAL;

			break;

		}



		break;