Commit 960b1fdf authored Nov 04, 2021 by Greg Kroah-Hartman

Revert "drm/ttm: fix memleak in ttm_transfered_destroy"

This reverts commit bd99782f which is
commit 0db55f9a1bafbe3dac750ea669de9134922389b5 upstream.

Seems that the older kernels can not handle this fix because, to quote
Christian:
	The problem is this memory leak could potentially happen with
	5.10 as wel, just much much much less likely.

	But my guess is that 5.10 is so buggy that when the leak does
	NOT happen we double free and obviously causing a crash.

So it needs to be reverted.

Link: https://lore.kernel.org/r/1a1cc125-9314-f569-a6c4-40fc4509a377@amd.com


Cc: Christian König <christian.koenig@amd.com>
Cc: Erhard F. <erhard_f@mailbox.org>
Cc: Erhard F. <erhard_f@mailbox.org>
Cc: Huang Rui <ray.huang@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a73ebe51

drivers/gpu/drm/ttm/ttm_bo_util.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -463,7 +463,6 @@ static void ttm_transfered_destroy(struct ttm_buffer_object *bo)
		struct ttm_transfer_obj *fbo;

		fbo = container_of(bo, struct ttm_transfer_obj, base);
		dma_resv_fini(&fbo->base.base._resv);
		ttm_bo_put(fbo->bo);
		kfree(fbo);
		}