Commit 95c2ef50 authored May 11, 2017 by Israel Rukshin Committed by Doug Ledford Jun 01, 2017

RDMA/srp: Fix NULL deref at srp_destroy_qp()



If srp_init_qp() fails at srp_create_ch_ib() then ch->send_cq
may be NULL.
Calling directly to ib_destroy_qp() is sufficient because
no work requests were posted on the created qp.

Fixes: 9294000d ("IB/srp: Drain the send queue before destroying a QP")
Cc: <stable@vger.kernel.org>
Signed-off-by: Israel Rukshin <israelr@mellanox.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com&gt;-->
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 0a1a9726

drivers/infiniband/ulp/srp/ib_srp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -575,7 +575,7 @@ static int srp_create_ch_ib(struct srp_rdma_ch *ch)
		return 0;

		err_qp:
		srp_destroy_qp(ch, qp);
		ib_destroy_qp(qp);

		err_send_cq:
		ib_free_cq(send_cq);