Commit 959ef6d5 authored Jul 15, 2014 by Himangi Saraogi Committed by Matthew Garrett Aug 16, 2014

WMI: Remove unnecessary null test



This patch removes the null test on block. block is initialized at the
beginning of the function to &wblock->gblock. Since wblock is
dereferenced prior to the null test, wblock must be a valid pointer,
and &wblock->gblock cannot be null.

The following Coccinelle script is used for detecting the change:

@r@
expression e,f;
identifier g,y;
statement S1,S2;
@@

*e = &f->g
<+...
 f->y
 ...+>
*if (e != NULL || ...)
 S1 else S2

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>

parent bd3c7b9e

drivers/platform/x86/wmi.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -256,10 +256,6 @@ static acpi_status wmi_method_enable(struct wmi_block *wblock, int enable)
		block = &wblock->gblock;
		handle = wblock->handle;

		if (!block)
		return AE_NOT_EXIST;


		snprintf(method, 5, "WE%02X", block->notify_id);
		status = acpi_execute_simple_method(handle, method, enable);