Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 952c699c authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Greg Kroah-Hartman
Browse files

Staging: batman-adv: Remove unneeded rcu_read_lock 



Regions which do not use rcu functions don't need to protected by
rcu_read_lock. If we want to protect data from being freed than it must
be covered by the same read-side critical section or otherwise the grace
period may already ended and freed the memory before we called
rcu_read_lock again.

Signed-off-by: default avatarSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 22508401

drivers/staging/batman-adv/originator.c

+0 −2
Original line number Diff line number Diff line
@@ -329,7 +329,6 @@ int orig_seq_print_text(struct seq_file *seq, void *offset) 
				  net_dev->name);

	}



	rcu_read_lock();

	seq_printf(seq, "[B.A.T.M.A.N. adv %s%s, MainIF/MAC: %s/%s (%s)]\n",

		   SOURCE_VERSION, REVISION_VERSION_STR,

		   bat_priv->primary_if->net_dev->name,
@@ -337,7 +336,6 @@ int orig_seq_print_text(struct seq_file *seq, void *offset) 
	seq_printf(seq, "  %-15s %s (%s/%i) %17s [%10s]: %20s ...\n",

		   "Originator", "last-seen", "#", TQ_MAX_VALUE, "Nexthop",

		   "outgoingIF", "Potential nexthops");

	rcu_read_unlock();



	spin_lock_irqsave(&bat_priv->orig_hash_lock, flags);