Commit 94e7c844 authored Sep 20, 2018 by Nathan Chancellor Committed by David S. Miller Sep 21, 2018

net: lan78xx: Avoid unnecessary self assignment

Clang warns when a variable is assigned to itself.

drivers/net/usb/lan78xx.c:940:11: warning: explicitly assigning value of
variable of type 'u32' (aka 'unsigned int') to itself [-Wself-assign]
                        offset = offset;
                        ~~~~~~ ^ ~~~~~~
1 warning generated.

Reorder the if statement to acheive the same result and avoid a self
assignment warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/129


Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6b8e327c

drivers/net/usb/lan78xx.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -936,11 +936,9 @@ static int lan78xx_read_otp(struct lan78xx_net *dev, u32 offset,
		ret = lan78xx_read_raw_otp(dev, 0, 1, &sig);

		if (ret == 0) {
		if (sig == OTP_INDICATOR_1)
		offset = offset;
		else if (sig == OTP_INDICATOR_2)
		if (sig == OTP_INDICATOR_2)
		offset += 0x100;
		else
		else if (sig != OTP_INDICATOR_1)
		ret = -EINVAL;
		if (!ret)
		ret = lan78xx_read_raw_otp(dev, offset, length, data);