Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94b7ed0a authored by Nikolay Kuratov's avatar Nikolay Kuratov Committed by Greg Kroah-Hartman
Browse files

net/sctp: Prevent autoclose integer overflow in sctp_association_init() 



commit 4e86729d1ff329815a6e8a920cb554a1d4cb5b8d upstream.

While by default max_autoclose equals to INT_MAX / HZ, one may set
net.sctp.max_autoclose to UINT_MAX. There is code in
sctp_association_init() that can consequently trigger overflow.

Cc: stable@vger.kernel.org
Fixes: 9f70f46b ("sctp: properly latch and use autoclose value from sock to association")
Signed-off-by: default avatarNikolay Kuratov <kniv@yandex-team.ru>
Acked-by: default avatarXin Long <lucien.xin@gmail.com>
Link: https://patch.msgid.link/20241219162114.2863827-1-kniv@yandex-team.ru


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9efc2a85

net/sctp/associola.c

+2 −1
Original line number Diff line number Diff line
@@ -132,7 +132,8 @@ static struct sctp_association *sctp_association_init( 
		= 5 * asoc->rto_max;



	asoc->timeouts[SCTP_EVENT_TIMEOUT_SACK] = asoc->sackdelay;

	asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE] = sp->autoclose * HZ;

	asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE] =

		(unsigned long)sp->autoclose * HZ;



	/* Initializes the timers */

	for (i = SCTP_EVENT_TIMEOUT_NONE; i < SCTP_NUM_TIMEOUT_TYPES; ++i)