Commit 9498f527 authored Oct 11, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Nov 17, 2021

memstick: jmb38x_ms: use appropriate free function in jmb38x_ms_alloc_host()



[ Upstream commit beae4a6258e64af609ad5995cc6b6056eb0d898e ]

The "msh" pointer is device managed, meaning that memstick_alloc_host()
calls device_initialize() on it.  That means that it can't be free
using kfree() but must instead be freed with memstick_free_host().
Otherwise it leads to a tiny memory leak of device resources.

Fixes: 60fdd931 ("memstick: add support for JMicron jmb38x MemoryStick host controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211011123912.GD15188@kili


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5f462b38

drivers/memstick/host/jmb38x_ms.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -899,7 +899,7 @@ static struct memstick_host jmb38x_ms_alloc_host(struct jmb38x_ms jm, int cnt)

		iounmap(host->addr);
		err_out_free:
		kfree(msh);
		memstick_free_host(msh);
		return NULL;
		}