Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9423fc2d authored by Fernando Yang's avatar Fernando Yang Committed by Greg Kroah-Hartman
Browse files

iio: adc: ad7266: Fix variable checking bug 



commit a2b86132955268b2a1703082fbc2d4832fc001b8 upstream.

The ret variable was not checked after iio_device_release_direct_mode(),
which could possibly cause errors

Fixes: c70df20e ("iio: adc: ad7266: claim direct mode during sensor read")
Signed-off-by: default avatarFernando Yang <hagisf@usp.br>
Link: https://lore.kernel.org/r/20240603180757.8560-1-hagisf@usp.br


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 605466fc

drivers/iio/adc/ad7266.c

+2 −0
Original line number Diff line number Diff line
@@ -159,6 +159,8 @@ static int ad7266_read_raw(struct iio_dev *indio_dev, 
		ret = ad7266_read_single(st, val, chan->address);

		iio_device_release_direct_mode(indio_dev);



		if (ret < 0)

			return ret;

		*val = (*val >> 2) & 0xfff;

		if (chan->scan_type.sign == 's')

			*val = sign_extend32(*val, 11);