Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93f8a98a authored by Johannes Berg's avatar Johannes Berg Committed by Greg Kroah-Hartman
Browse files

um: virtio_uml: fix memory leak on init failures 



commit 7ad28e0df7ee9dbcb793bb88dd81d4d22bb9a10e upstream.

If initialization fails, e.g. because the connection failed,
we leak the 'vu_dev'. Fix that. Reported by smatch.

Fixes: 5d38f324 ("um: drivers: Add virtio vhost-user driver")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Acked-By: default avatarAnton Ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4cd05e39

arch/um/drivers/virtio_uml.c

+3 −1
Original line number Diff line number Diff line
@@ -994,7 +994,7 @@ static int virtio_uml_probe(struct platform_device *pdev) 
		rc = os_connect_socket(pdata->socket_path);

	} while (rc == -EINTR);

	if (rc < 0)

		return rc;

		goto error_free;

	vu_dev->sock = rc;



	rc = vhost_user_init(vu_dev);
@@ -1010,6 +1010,8 @@ static int virtio_uml_probe(struct platform_device *pdev) 


error_init:

	os_close_file(vu_dev->sock);

error_free:

	kfree(vu_dev);

	return rc;

}