Commit 93b26052 authored Feb 28, 2019 by Dan Carpenter Committed by Andy Gross Mar 27, 2019

soc: qcom: cmd-db: Fix an error code in cmd_db_dev_probe()



The memremap() function doesn't return error pointers, it returns NULL.
This code is returning "ret = PTR_ERR(NULL);" which is success, but it
should return -ENOMEM.

Fixes: 312416d9 ("drivers: qcom: add command DB driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>

parent 9324df58

drivers/soc/qcom/cmd-db.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -248,8 +248,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev)
		}

		cmd_db_header = memremap(rmem->base, rmem->size, MEMREMAP_WB);
		if (IS_ERR_OR_NULL(cmd_db_header)) {
		ret = PTR_ERR(cmd_db_header);
		if (!cmd_db_header) {
		ret = -ENOMEM;
		cmd_db_header = NULL;
		return ret;
		}