Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 935035cf authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

ARM: OMAP2+: Fix refcount leak in omapdss_init_of 



[ Upstream commit 9705db1eff38d6b9114121f9e253746199b759c9 ]

omapdss_find_dss_of_node() calls of_find_compatible_node() to get device
node. of_find_compatible_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() in later error path and normal path.

Fixes: e0c827ac ("drm/omap: Populate DSS children in omapdss driver")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Message-Id: <20220601044858.3352-1-linmq006@gmail.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b95e19f1

arch/arm/mach-omap2/display.c

+2 −0
Original line number Diff line number Diff line
@@ -260,11 +260,13 @@ static int __init omapdss_init_of(void) 


	if (!pdev) {

		pr_err("Unable to find DSS platform device\n");

		of_node_put(node);

		return -ENODEV;

	}



	r = of_platform_populate(node, NULL, NULL, &pdev->dev);

	put_device(&pdev->dev);

	of_node_put(node);

	if (r) {

		pr_err("Unable to populate DSS submodule devices\n");

		return r;