Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 933bfe4d authored by Tobias Jakobi's avatar Tobias Jakobi Committed by Jiri Kosina
Browse files

HID: usbhid: extend polling interval configuration to joysticks 



For mouse devices we can currently change the polling interval
via usbhid.mousepoll. Implement the same thing for joysticks, so
users can reduce input latency this way.

This has been tested with a Logitech RumblePad 2 with jspoll=2,
resulting in a polling rate of 500Hz (verified with evhz).

Signed-off-by: default avatarTobias Jakobi <tjakobi@math.uni-bielefeld.de>
Acked-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 81bbef23

Documentation/admin-guide/kernel-parameters.txt

+3 −0
Original line number Diff line number Diff line
@@ -4085,6 +4085,9 @@ 
	usbhid.mousepoll=

			[USBHID] The interval which mice are to be polled at.



	usbhid.jspoll=

			[USBHID] The interval which joysticks are to be polled at.



	usb-storage.delay_use=

			[UMS] The delay in seconds before a new device is

			scanned for Logical Units (default 1).

drivers/hid/usbhid/hid-core.c

+15 −3
Original line number Diff line number Diff line
@@ -52,6 +52,10 @@ static unsigned int hid_mousepoll_interval; 
module_param_named(mousepoll, hid_mousepoll_interval, uint, 0644);

MODULE_PARM_DESC(mousepoll, "Polling interval of mice");



static unsigned int hid_jspoll_interval;

module_param_named(jspoll, hid_jspoll_interval, uint, 0644);

MODULE_PARM_DESC(jspoll, "Polling interval of joysticks");



static unsigned int ignoreled;

module_param_named(ignoreled, ignoreled, uint, 0644);

MODULE_PARM_DESC(ignoreled, "Autosuspend with active leds");
@@ -1081,9 +1085,17 @@ static int usbhid_start(struct hid_device *hid) 
			       hid->name, endpoint->bInterval, interval);

		}



		/* Change the polling interval of mice. */

		if (hid->collection->usage == HID_GD_MOUSE && hid_mousepoll_interval > 0)

		/* Change the polling interval of mice and joysticks. */

		switch (hid->collection->usage) {

		case HID_GD_MOUSE:

			if (hid_mousepoll_interval > 0)

				interval = hid_mousepoll_interval;

			break;

		case HID_GD_JOYSTICK:

			if (hid_jspoll_interval > 0)

				interval = hid_jspoll_interval;

			break;

		}



		ret = -ENOMEM;

		if (usb_endpoint_dir_in(endpoint)) {