Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9315d904 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Vinod Koul
Browse files

soundwire: stream: fix bad unlock balance 



the msg lock is taken for multi-link cases only but released
unconditionally, leading to an unlock balance warning for single-link usages
This patch fixes this.

 =====================================
 WARNING: bad unlock balance detected!
 5.1.0-16506-gc1c383a6f0a2-dirty #1523 Tainted: G        W
 -------------------------------------
 aplay/2954 is trying to release lock (&bus->msg_lock) at:
 do_bank_switch+0x21c/0x480
 but there are no more locks to release!

Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: default avatarSanyog Kale <sanyog.r.kale@intel.com>
[vkoul: edited the change log as suggested by Pierre]
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 03ecad90

drivers/soundwire/stream.c

+2 −1
Original line number Diff line number Diff line
@@ -814,6 +814,7 @@ static int do_bank_switch(struct sdw_stream_runtime *stream) 
			goto error;

		}



		if (bus->multi_link)

			mutex_unlock(&bus->msg_lock);

	}