Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 927907f1 authored by James Smart's avatar James Smart Committed by Greg Kroah-Hartman
Browse files

scsi: lpfc: Prevent buffer overflow crashes in debugfs with malformed user input 

[ Upstream commit f8191d40aa612981ce897e66cda6a88db8df17bb ]

Malformed user input to debugfs results in buffer overflow crashes.  Adapt
input string lengths to fit within internal buffers, leaving space for NULL
terminators.

Link: https://lore.kernel.org/r/20220701211425.2708-3-jsmart2021@gmail.com


Co-developed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d401611a

drivers/scsi/lpfc/lpfc_debugfs.c

+10 −10
Original line number Diff line number Diff line
@@ -2402,8 +2402,8 @@ lpfc_debugfs_multixripools_write(struct file *file, const char __user *buf, 
	struct lpfc_sli4_hdw_queue *qp;

	struct lpfc_multixri_pool *multixri_pool;



	if (nbytes > 64)

		nbytes = 64;

	if (nbytes > sizeof(mybuf) - 1)

		nbytes = sizeof(mybuf) - 1;



	/* Protect copy from user */

	if (!access_ok(buf, nbytes))
@@ -2487,8 +2487,8 @@ lpfc_debugfs_nvmestat_write(struct file *file, const char __user *buf, 
	if (!phba->targetport)

		return -ENXIO;



	if (nbytes > 64)

		nbytes = 64;

	if (nbytes > sizeof(mybuf) - 1)

		nbytes = sizeof(mybuf) - 1;



	memset(mybuf, 0, sizeof(mybuf));
@@ -2629,8 +2629,8 @@ lpfc_debugfs_nvmektime_write(struct file *file, const char __user *buf, 
	char mybuf[64];

	char *pbuf;



	if (nbytes > 64)

		nbytes = 64;

	if (nbytes > sizeof(mybuf) - 1)

		nbytes = sizeof(mybuf) - 1;



	memset(mybuf, 0, sizeof(mybuf));
@@ -2757,8 +2757,8 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf, 
	char mybuf[64];

	char *pbuf;



	if (nbytes > 63)

		nbytes = 63;

	if (nbytes > sizeof(mybuf) - 1)

		nbytes = sizeof(mybuf) - 1;



	memset(mybuf, 0, sizeof(mybuf));
@@ -2863,8 +2863,8 @@ lpfc_debugfs_cpucheck_write(struct file *file, const char __user *buf, 
	char *pbuf;

	int i, j;



	if (nbytes > 64)

		nbytes = 64;

	if (nbytes > sizeof(mybuf) - 1)

		nbytes = sizeof(mybuf) - 1;



	memset(mybuf, 0, sizeof(mybuf));