video: fbdev: uvesafb: Remove impossible code path in uvesafb_init_info (92559977) · Commits · e / devices / android_kernel_fairphone_FP5

Because uvesafb_vbe_init will fail when get zero avaiable modes, and we have checked the return value of uvesafb_vbe_init_mode, so it is impossible to pass NULL as mode into uvesafb_init_info. [ This patch fix warning report by fengguang.wu@intel.com "drivers/video/fbdev/uvesafb.c:1509 uvesafb_init_info() error: we previously assumed 'mode' could be null" ] Signed-off-by:

Wang YanQing <udknight@gmail.com> Signed-off-by:

Tomi Valkeinen <tomi.valkeinen@ti.com>

drivers/video/uvesafb.c

+1 −6

Original line number	Original line	Diff line number	Diff line
	@@ -1474,12 +1474,7 @@ static void uvesafb_init_info(struct fb_info info, struct vbe_mode_ib mode)
	* used video mode, i.e. the minimum amount of		* used video mode, i.e. the minimum amount of
	* memory we need.		* memory we need.
	*/		*/
	if (mode != NULL) {
	size_vmode = info->var.yres * mode->bytes_per_scan_line;		size_vmode = info->var.yres * mode->bytes_per_scan_line;
	} else {
	size_vmode = info->var.yres * info->var.xres *
	((info->var.bits_per_pixel + 7) >> 3);
	}

	/*		/*
	* size_total -- all video memory we have. Used for mtrr		* size_total -- all video memory we have. Used for mtrr