Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 920ac5be authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Sebastian Reichel
Browse files

power: max8925: Fix NULL ptr dereference on memory allocation failure 



Check the return value of devm_kzalloc() to fix possible NULL pointer
dereference and properly exit the probe() on memory allocation failure.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 628ef02c

drivers/power/max8925_power.c

+4 −1
Original line number Diff line number Diff line
@@ -452,13 +452,14 @@ max8925_power_dt_init(struct platform_device *pdev) 
	pdata = devm_kzalloc(&pdev->dev,

			sizeof(struct max8925_power_pdata),

			GFP_KERNEL);

	if (!pdata)

		goto ret;



	of_property_read_u32(np, "topoff-threshold", &topoff_threshold);

	of_property_read_u32(np, "batt-detect", &batt_detect);

	of_property_read_u32(np, "fast-charge", &fast_charge);

	of_property_read_u32(np, "no-insert-detect", &no_insert_detect);

	of_property_read_u32(np, "no-temp-support", &no_temp_support);

	of_node_put(np);



	pdata->batt_detect = batt_detect;

	pdata->fast_charge = fast_charge;
@@ -466,6 +467,8 @@ max8925_power_dt_init(struct platform_device *pdev) 
	pdata->no_insert_detect = no_insert_detect;

	pdata->no_temp_support = no_temp_support;



ret:

	of_node_put(np);

	return pdata;

}

#else