Commit 91d8d7ed authored May 06, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman May 25, 2022

ethernet: tulip: fix missing pci_disable_device() on error in tulip_init_one()



[ Upstream commit 51ca86b4c9c7c75f5630fa0dbe5f8f0bd98e3c3e ]

Fix the missing pci_disable_device() before return
from tulip_init_one() in the error handling case.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220506094250.3630615-1-yangyingliang@huawei.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent dd5de66f

drivers/net/ethernet/dec/tulip/tulip_core.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1410,8 +1410,10 @@ static int tulip_init_one(struct pci_dev pdev, const struct pci_device_id ent)

		/* alloc_etherdev ensures aligned and zeroed private structures */
		dev = alloc_etherdev (sizeof (*tp));
		if (!dev)
		if (!dev) {
		pci_disable_device(pdev);
		return -ENOMEM;
		}

		SET_NETDEV_DEV(dev, &pdev->dev);
		if (pci_resource_len (pdev, 0) < tulip_tbl[chip_idx].io_size) {
		@@ -1788,6 +1790,7 @@ static int tulip_init_one(struct pci_dev pdev, const struct pci_device_id ent)

		err_out_free_netdev:
		free_netdev (dev);
		pci_disable_device(pdev);
		return -ENODEV;
		}