Commit 91be2587 authored Aug 12, 2019 by Thomas Gleixner

x86/fpu/math-emu: Address fallthrough warnings



/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/errors.c: In function ‘FPU_printall’:
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/errors.c:187:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
    tagi = FPU_Special(r);
    ~~~~~^~~~~~~~~~~~~~~~
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/errors.c:188:3: note: here
   case TAG_Valid:
   ^~~~
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/fpu_trig.c: In function ‘fyl2xp1’:
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/fpu_trig.c:1353:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (denormal_operand() < 0)
       ^
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/fpu_trig.c:1356:3: note: here
   case TAG_Zero:

Remove the pointless 'break;' after 'continue;' while at it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 5785675d

arch/x86/math-emu/errors.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -178,13 +178,15 @@ void FPU_printall(void)
		for (i = 0; i < 8; i++) {
		FPU_REG *r = &st(i);
		u_char tagi = FPU_gettagi(i);

		switch (tagi) {
		case TAG_Empty:
		continue;
		break;
		case TAG_Zero:
		case TAG_Special:
		/* Update tagi for the printk below */
		tagi = FPU_Special(r);
		/* fall through */
		case TAG_Valid:
		printk("st(%d) %c .%04lx %04lx %04lx %04lx e%+-6d ", i,
		getsign(r) ? '-' : '+',
		@@ -198,7 +200,6 @@ void FPU_printall(void)
		printk("Whoops! Error in errors.c: tag%d is %d ", i,
		tagi);
		continue;
		break;
		}
		printk("%s\n", tag_desc[(int)(unsigned)tagi]);
		}

arch/x86/math-emu/fpu_trig.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1352,7 +1352,7 @@ static void fyl2xp1(FPU_REG *st0_ptr, u_char st0_tag)
		case TW_Denormal:
		if (denormal_operand() < 0)
		return;

		/* fall through */
		case TAG_Zero:
		case TAG_Valid:
		setsign(st0_ptr, getsign(st0_ptr) ^ getsign(st1_ptr));