Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9198eefd authored by Kees Cook's avatar Kees Cook Committed by Greg Kroah-Hartman
Browse files

usb: gadget: udc: Avoid tasklet passing a global 



[ Upstream commit f9dc3713df1229aa8168169e9cf1010fbac68de5 ]

There's no reason for the tasklet callback to set an argument since it
always uses a global. Instead, use the global directly, in preparation
for converting the tasklet subsystem to modern callback conventions.

Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Stable-dep-of: 1fdeb8b9f29d ("wifi: iwl3945: Add missing check for create_singlethread_workqueue")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent cf04507f

drivers/usb/gadget/udc/snps_udc_core.c

+2 −4
Original line number Diff line number Diff line
@@ -96,9 +96,7 @@ static int stop_pollstall_timer; 
static DECLARE_COMPLETION(on_pollstall_exit);



/* tasklet for usb disconnect */

static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect,

		(unsigned long) &udc);



static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect, 0);



/* endpoint names used for print */

static const char ep0_string[] = "ep0in";
@@ -1661,7 +1659,7 @@ static void usb_disconnect(struct udc *dev) 
/* Tasklet for disconnect to be outside of interrupt context */

static void udc_tasklet_disconnect(unsigned long par)

{

	struct udc *dev = (struct udc *)(*((struct udc **) par));

	struct udc *dev = udc;

	u32 tmp;



	DBG(dev, "Tasklet disconnect\n");