Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91883cd2 authored by Ilya Dryomov's avatar Ilya Dryomov Committed by Ilya Dryomov
Browse files

libceph: don't try checking queue_work() return value 



queue_work() doesn't "fail to queue", it returns false if work was
already on a queue, which can't happen here since we allocate
event_work right before we queue it.  So don't bother at all.

Signed-off-by: default avatarIlya Dryomov <ilya.dryomov@inktank.com>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
parent 03974e81

net/ceph/osd_client.c

+5 −10
Original line number Diff line number Diff line
@@ -2358,24 +2358,19 @@ static void handle_watch_notify(struct ceph_osd_client *osdc, 
	if (event) {

		event_work = kmalloc(sizeof(*event_work), GFP_NOIO);

		if (!event_work) {

			dout("ERROR: could not allocate event_work\n");

			goto done_err;

			pr_err("couldn't allocate event_work\n");

			ceph_osdc_put_event(event);

			return;

		}

		INIT_WORK(&event_work->work, do_event_work);

		event_work->event = event;

		event_work->ver = ver;

		event_work->notify_id = notify_id;

		event_work->opcode = opcode;

		if (!queue_work(osdc->notify_wq, &event_work->work)) {

			dout("WARNING: failed to queue notify event work\n");

			goto done_err;

		}

	}



	return;

		queue_work(osdc->notify_wq, &event_work->work);

	}



done_err:

	ceph_osdc_put_event(event);

	return;



bad: