Commit 914c58fe authored Aug 30, 2022 by Randy Dunlap Committed by Greg Kroah-Hartman Feb 06, 2023

net: mlx5: eliminate anonymous module_init & module_exit



[ Upstream commit 2c1e1b949024989e20907b84e11a731a50778416 ]

Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.

Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.

Example 1: (System.map)
 ffffffff832fc78c t init
 ffffffff832fc79e t init
 ffffffff832fc8f8 t init

Example 2: (initcall_debug log)
 calling  init+0x0/0x12 @ 1
 initcall init+0x0/0x12 returned 0 after 15 usecs
 calling  init+0x0/0x60 @ 1
 initcall init+0x0/0x60 returned 0 after 2 usecs
 calling  init+0x0/0x9a @ 1
 initcall init+0x0/0x9a returned 0 after 74 usecs

Fixes: e126ba97 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Eli Cohen <eli@mellanox.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 7335ba0c

drivers/net/ethernet/mellanox/mlx5/core/main.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1640,7 +1640,7 @@ static void mlx5_core_verify_params(void)
		}
		}

		static int __init init(void)
		static int __init mlx5_init(void)
		{
		int err;

		@@ -1665,7 +1665,7 @@ static int __init init(void)
		return err;
		}

		static void __exit cleanup(void)
		static void __exit mlx5_cleanup(void)
		{
		#ifdef CONFIG_MLX5_CORE_EN
		mlx5e_cleanup();
		@@ -1674,5 +1674,5 @@ static void __exit cleanup(void)
		mlx5_unregister_debugfs();
		}

		module_init(init);
		module_exit(cleanup);
		module_init(mlx5_init);
		module_exit(mlx5_cleanup);