Commit 91274bbe authored Jun 19, 2023 by Francesco Dolcini Committed by Greg Kroah-Hartman Jun 28, 2023

Revert "net: phy: dp83867: perform soft reset and retain established link"

[ Upstream commit a129b41fe0a8b4da828c46b10f5244ca07a3fec3 ]

This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.

This fixes a regression in which the link would come up, but no
communication was possible.

The reverted commit was also removing a comment about
DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
since it seems that this is unrelated to the original code change.

Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/


Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Praneeth Bajjuri <praneeth@ti.com>
Link: https://lore.kernel.org/r/20230619154435.355485-1-francesco@dolcini.it


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 25c8d38c

drivers/net/phy/dp83867.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -476,7 +476,7 @@ static int dp83867_phy_reset(struct phy_device *phydev)
		{
		int err;

		err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESTART);
		err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESET);
		if (err < 0)
		return err;