Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90c6260c authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Jonathan Cameron
Browse files

iio: adc: gyroadc: fix uninitialized return code 



gcc-9 complains about a blatant uninitialized variable use that
all earlier compiler versions missed:

drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Return -EINVAL instead here and a few lines above it where
we accidentally return 0 on failure.

Cc: stable@vger.kernel.org
Fixes: 059c53b3 ("iio: adc: Add Renesas GyroADC driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 41e6ada9

drivers/iio/adc/rcar-gyroadc.c

+2 −2
Original line number Diff line number Diff line
@@ -382,7 +382,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) 
				dev_err(dev,

					"Only %i channels supported with %pOFn, but reg = <%i>.\n",

					num_channels, child, reg);

				return ret;

				return -EINVAL;

			}

		}
@@ -391,7 +391,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) 
			dev_err(dev,

				"Channel %i uses different ADC mode than the rest.\n",

				reg);

			return ret;

			return -EINVAL;

		}



		/* Channel is valid, grab the regulator. */