Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9068b032 authored by Vinod Koul's avatar Vinod Koul
Browse files

dmaengine: pch_dma: use tasklet_kill in teardown 

As discussed in [1] the tasklet_disable is not a proper function for teardown.
We need to ensure irq is disabled, followed by ensuring that don't schedule any
more tasklets and then its safe to use tasklet_kill().

Here in pch dma driver we need to use free_irq() before tasklet_kill(). So move
up the free_irq() which will ensure that the irq is disabled and also wait till
all scheduled interrupts are executed by invoking synchronize_irq().

[1]: http://lwn.net/Articles/588457/



Reported-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent ccc7aad0

drivers/dma/pch_dma.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -964,16 +964,16 @@ static void pch_dma_remove(struct pci_dev *pdev) 
	if (pd) {

	if (pd) {

		dma_async_device_unregister(&pd->dma);

		dma_async_device_unregister(&pd->dma);





		free_irq(pdev->irq, pd);



		list_for_each_entry_safe(chan, _c, &pd->dma.channels,

		list_for_each_entry_safe(chan, _c, &pd->dma.channels,

					 device_node) {

					 device_node) {

			pd_chan = to_pd_chan(chan);

			pd_chan = to_pd_chan(chan);





			tasklet_disable(&pd_chan->tasklet);

			tasklet_kill(&pd_chan->tasklet);

			tasklet_kill(&pd_chan->tasklet);

		}

		}





		pci_pool_destroy(pd->pool);

		pci_pool_destroy(pd->pool);

		free_irq(pdev->irq, pd);

		pci_iounmap(pdev, pd->membase);

		pci_iounmap(pdev, pd->membase);

		pci_release_regions(pdev);

		pci_release_regions(pdev);

		pci_disable_device(pdev);

		pci_disable_device(pdev);