Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9042a9a3 authored by Szymon Heidrich's avatar Szymon Heidrich Committed by Greg Kroah-Hartman
Browse files

wifi: rndis_wlan: Prevent buffer overflow in rndis_query_oid 



[ Upstream commit b870e73a56c4cccbec33224233eaf295839f228c ]

Since resplen and respoffs are signed integers sufficiently
large values of unsigned int len and offset members of RNDIS
response will result in negative values of prior variables.
This may be utilized to bypass implemented security checks
to either extract memory contents by manipulating offset or
overflow the data buffer via memcpy by manipulating both
offset and len.

Additionally assure that sum of resplen and respoffs does not
overflow so buffer boundaries are kept.

Fixes: 80f8c5b4 ("rndis_wlan: copy only useful data from rndis_command respond")
Signed-off-by: default avatarSzymon Heidrich <szymon.heidrich@gmail.com>
Reviewed-by: default avatarAlexander Duyck <alexanderduyck@fb.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230111175031.7049-1-szymon.heidrich@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent de0e084f

drivers/net/wireless/rndis_wlan.c

+6 −13
Original line number Diff line number Diff line
@@ -700,8 +700,8 @@ static int rndis_query_oid(struct usbnet *dev, u32 oid, void *data, int *len) 
		struct rndis_query	*get;

		struct rndis_query_c	*get_c;

	} u;

	int ret, buflen;

	int resplen, respoffs, copylen;

	int ret;

	size_t buflen, resplen, respoffs, copylen;



	buflen = *len + sizeof(*u.get);

	if (buflen < CONTROL_BUFFER_SIZE)
@@ -736,22 +736,15 @@ static int rndis_query_oid(struct usbnet *dev, u32 oid, void *data, int *len) 


		if (respoffs > buflen) {

			/* Device returned data offset outside buffer, error. */

			netdev_dbg(dev->net, "%s(%s): received invalid "

				"data offset: %d > %d\n", __func__,

				oid_to_string(oid), respoffs, buflen);

			netdev_dbg(dev->net,

				   "%s(%s): received invalid data offset: %zu > %zu\n",

				   __func__, oid_to_string(oid), respoffs, buflen);



			ret = -EINVAL;

			goto exit_unlock;

		}



		if ((resplen + respoffs) > buflen) {

			/* Device would have returned more data if buffer would

			 * have been big enough. Copy just the bits that we got.

			 */

			copylen = buflen - respoffs;

		} else {

			copylen = resplen;

		}

		copylen = min(resplen, buflen - respoffs);



		if (copylen > *len)

			copylen = *len;