Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 902a8a0b authored Sep 06, 2016 by Arnd Bergmann Committed by Ulf Hansson Sep 26, 2016

mmc: davinci: remove incorrect NO_IRQ use



platform_get_irq() returns an error value on failure, not NO_IRQ,
so the error handling here could never work.

This changes the code to propagate the error value instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 7428e0bf

drivers/mmc/host/davinci_mmc.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1216,9 +1216,11 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
		}

		r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		irq = platform_get_irq(pdev, 0);
		if (!r \|\| irq == NO_IRQ)
		if (!r)
		return -ENODEV;
		irq = platform_get_irq(pdev, 0);
		if (irq < 0)
		return irq;

		mem_size = resource_size(r);
		mem = devm_request_mem_region(&pdev->dev, r->start, mem_size,