Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ffa40ff authored by Thomas Zimmermann's avatar Thomas Zimmermann Committed by Greg Kroah-Hartman
Browse files

fbdev/ep93xx-fb: Do not assign to struct fb_info.dev 



commit f90a0e5265b60cdd3c77990e8105f79aa2fac994 upstream.

Do not assing the Linux device to struct fb_info.dev. The call to
register_framebuffer() initializes the field to the fbdev device.
Drivers should not override its value.

Fixes a bug where the driver incorrectly decreases the hardware
device's reference counter and leaks the fbdev device.

v2:
	* add Fixes tag (Dan)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Fixes: 88017bda ("ep93xx video driver")
Cc: <stable@vger.kernel.org> # v2.6.32+
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230613110953.24176-15-tzimmermann@suse.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6d5eb57a

drivers/video/fbdev/ep93xx-fb.c

+0 −1
Original line number Diff line number Diff line
@@ -474,7 +474,6 @@ static int ep93xxfb_probe(struct platform_device *pdev) 
	if (!info)

		return -ENOMEM;



	info->dev = &pdev->dev;

	platform_set_drvdata(pdev, info);

	fbi = info->par;

	fbi->mach_info = mach_info;