Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 8faef87e authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Mark Brown
Browse files

ASoC: intel: skl_nau88l25_ssm4567: Replace GFP_ATOMIC with GFP_KERNEL in skylake_audio_probe 



skylake_audio_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".

Despite never getting called from atomic context,
skylake_audio_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3afce6a4

sound/soc/intel/boards/skl_nau88l25_ssm4567.c

+1 −1
Original line number Diff line number Diff line
@@ -696,7 +696,7 @@ static int skylake_audio_probe(struct platform_device *pdev) 
	struct skl_nau88125_private *ctx;

	struct skl_machine_pdata *pdata;



	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC);

	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);

	if (!ctx)

		return -ENOMEM;