Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fabc0eb authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva
Browse files

scsi: bfa: bfa_fcpim: Mark expected switch fall-throughs 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that I replaced "Fall through !!!" with a "fall through"
annotation, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114971 ("Missing break in switch")
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
parent a8308767

drivers/scsi/bfa/bfa_fcpim.c

+3 −3
Original line number Diff line number Diff line
@@ -2586,6 +2586,7 @@ bfa_ioim_send_ioreq(struct bfa_ioim_s *ioim) 
	case FCP_IODIR_RW:

		bfa_stats(itnim, input_reqs);

		bfa_stats(itnim, output_reqs);

		/* fall through */

	default:

		bfi_h2i_set(m->mh, BFI_MC_IOIM_IO, 0, bfa_fn_lpu(ioim->bfa));

	}
@@ -2820,6 +2821,7 @@ bfa_ioim_isr(struct bfa_s *bfa, struct bfi_msg_s *m) 


	case BFI_IOIM_STS_TIMEDOUT:

		bfa_stats(ioim->itnim, iocomp_timedout);

		/* fall through */

	case BFI_IOIM_STS_ABORTED:

		rsp->io_status = BFI_IOIM_STS_ABORTED;

		bfa_stats(ioim->itnim, iocomp_aborted);
@@ -3215,9 +3217,7 @@ bfa_tskim_sm_cleanup_qfull(struct bfa_tskim_s *tskim, 
	switch (event) {

	case BFA_TSKIM_SM_DONE:

		bfa_reqq_wcancel(&tskim->reqq_wait);

		/*

		 * Fall through !!!

		 */

		/* fall through */

	case BFA_TSKIM_SM_QRESUME:

		bfa_sm_set_state(tskim, bfa_tskim_sm_cleanup);

		bfa_tskim_send_abort(tskim);