Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fa80b45 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe 



[ Upstream commit e1d6ca042e62c2a69513235f8629eb6e62ca79c5 ]

The svc_create_memory_pool() function returns error pointers.  It never
returns NULL.  Fix the check.

Fixes: 7ca5ce89 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/5f9a8cb4-5a4f-460b-9cdc-2fae6c5b7922@kili.mountain


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 26ca3051

drivers/firmware/stratix10-svc.c

+2 −2
Original line number Diff line number Diff line
@@ -981,8 +981,8 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev) 
		return ret;



	genpool = svc_create_memory_pool(pdev, sh_memory);

	if (!genpool)

		return -ENOMEM;

	if (IS_ERR(genpool))

		return PTR_ERR(genpool);



	/* allocate service controller and supporting channel */

	controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL);