Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f9a0981 authored by Murali Karicheri's avatar Murali Karicheri Committed by Sekhar Nori
Browse files

ARM: davinci: psc: fix incorrect mask 



There are 5 LSB bits defined in PDSTAT and the code
currently uses a mask of 1 bit to check the status.

Use a proper mask per the hardware specification.
While at it, use a #define for the mask to improve
readability.

Reviewed-by: default avatarSergei Shtylyov <sshtylyov@mvista.com>
Signed-off-by: default avatarMurali Karicheri <m-karicheri2@ti.com>
Signed-off-by: default avatarSekhar Nori <nsekhar@ti.com>
parent 5611cc45

arch/arm/mach-davinci/include/mach/psc.h

+1 −0
Original line number Diff line number Diff line
@@ -244,6 +244,7 @@ 
#define PSC_STATE_ENABLE	3



#define MDSTAT_STATE_MASK	0x3f

#define PDSTAT_STATE_MASK	0x1f

#define MDCTL_FORCE		BIT(31)



#ifndef __ASSEMBLER__

arch/arm/mach-davinci/psc.c

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ void davinci_psc_config(unsigned int domain, unsigned int ctlr, 
	__raw_writel(mdctl, psc_base + MDCTL + 4 * id);



	pdstat = __raw_readl(psc_base + PDSTAT);

	if ((pdstat & 0x00000001) == 0) {

	if ((pdstat & PDSTAT_STATE_MASK) == 0) {

		pdctl1 = __raw_readl(psc_base + PDCTL1);

		pdctl1 |= 0x1;

		__raw_writel(pdctl1, psc_base + PDCTL1);