Commit 8f8ff913 authored Aug 17, 2015 by Richard Alpe Committed by David S. Miller Aug 17, 2015

tipc: don't sanity check non-existing TLV (NL compat)



A zero length payload means that no TLV (Type Length Value) data has
been passed. Prior to this patch a non-existing TLV could be sanity
checked with TLV_OK() resulting in random behavior where a user
sending an empty message occasionally got a incorrect "operation not
supported" message back.

Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent da3cc2da

net/tipc/netlink_compat.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1114,7 +1114,7 @@ static int tipc_nl_compat_recv(struct sk_buff skb, struct genl_info info)
		}

		len = nlmsg_attrlen(req_nlh, GENL_HDRLEN + TIPC_GENL_HDRLEN);
		if (TLV_GET_LEN(msg.req) && !TLV_OK(msg.req, len)) {
		if (len && !TLV_OK(msg.req, len)) {
		msg.rep = tipc_get_err_tlv(TIPC_CFG_NOT_SUPPORTED);
		err = -EOPNOTSUPP;
		goto send;