Commit 8ee065a7 authored Mar 08, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Mar 16, 2022

ethernet: Fix error handling in xemaclite_of_probe



[ Upstream commit b19ab4b38b06aae12442b2de95ccf58b5dc53584 ]

This node pointer is returned by of_parse_phandle() with refcount
incremented in this function. Calling of_node_put() to avoid the
refcount leak. As the remove function do.

Fixes: 5cdaaa12 ("net: emaclite: adding MDIO and phy lib support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220308024751.2320-1-linmq006@gmail.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4c0b769d

drivers/net/ethernet/xilinx/xilinx_emaclite.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1187,7 +1187,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
		if (rc) {
		dev_err(dev,
		"Cannot register network device, aborting\n");
		goto error;
		goto put_node;
		}

		dev_info(dev,
		@@ -1195,6 +1195,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
		(unsigned int __force)ndev->mem_start, lp->base_addr, ndev->irq);
		return 0;

		put_node:
		of_node_put(lp->phy_node);
		error:
		free_netdev(ndev);
		return rc;